Enhance Logs readability of SDK Conformance Tests #1453

aLekSer · 2020-04-07T15:50:28Z

Add more detaied logging for local SDK server. Make npm and apt-get less noisy. apt-get install openjdk-8-jre spares about 25% of output.

For #1452 .

agones-bot · 2020-04-07T16:07:39Z

Build Succeeded 👏

Build Id: ba75c5bb-4540-4194-8836-ab2e69062782

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-8f273a1
image: gcr.io/agones-images/agones-sdk:1.5.0-8f273a1
image: gcr.io/agones-images/agones-ping:1.5.0-8f273a1
Linux C++ SDK (build): agonessdk-1.5.0-8f273a1-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-8f273a1.zip

A preview of the website (the last 30 builds are retained):

https://8f273a1-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1453/head:pr_1453 && git checkout pr_1453
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-8f273a1

agones-bot · 2020-04-08T13:30:54Z

Build Succeeded 👏

Build Id: c8cc227f-f1f0-4550-aa3d-df41d49362b4

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-416d785
image: gcr.io/agones-images/agones-sdk:1.5.0-416d785
image: gcr.io/agones-images/agones-ping:1.5.0-416d785
Linux C++ SDK (build): agonessdk-1.5.0-416d785-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-416d785.zip

A preview of the website (the last 30 builds are retained):

https://416d785-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1453/head:pr_1453 && git checkout pr_1453
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-416d785

agones-bot · 2020-04-08T13:35:48Z

Build Succeeded 👏

Build Id: d9602fd4-1665-44fe-86cc-195ff6d3fb8c

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.5.0-08fb8dc
image: gcr.io/agones-images/agones-sdk:1.5.0-08fb8dc
image: gcr.io/agones-images/agones-ping:1.5.0-08fb8dc
Linux C++ SDK (build): agonessdk-1.5.0-08fb8dc-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.5.0-08fb8dc.zip

A preview of the website (the last 30 builds are retained):

https://08fb8dc-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1453/head:pr_1453 && git checkout pr_1453
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.5.0-08fb8dc

markmandel

LGTM! Happy to approve once we are out of feature freeze!

markmandel · 2020-04-09T18:43:57Z

build/build-sdk-images/node/build-sdk-test.sh

@@ -15,8 +15,8 @@
 # limitations under the License.

 cd /go/src/agones.dev/agones/test/sdk/nodejs
-npm install
-npm rebuild
+npm install --quiet


markmandel · 2020-04-09T18:44:09Z

build/build-sdk-images/restapi/Dockerfile

 RUN curl -sL https://deb.nodesource.com/setup_12.x | bash - && \
-    apt-get install -y nodejs
+    apt-get install -qq -y nodejs


Also nice! Good idea to reduce the noise!

markmandel · 2020-04-09T18:44:26Z

build/includes/sdk.mk

@@ -143,7 +143,7 @@ run-sdk-conformance-no-build: FEATURE_GATES ?=
 run-sdk-conformance-no-build: ensure-agones-sdk-image
 run-sdk-conformance-no-build: ensure-build-sdk-image
 	DOCKER_RUN_ARGS="--net host -e AGONES_SDK_GRPC_PORT=$(GRPC_PORT) -e AGONES_SDK_HTTP_PORT=$(HTTP_PORT) -e FEATURE_GATES=$(FEATURE_GATES) $(DOCKER_RUN_ARGS)" COMMAND=sdktest $(MAKE) run-sdk-command & \
-	docker run -p $(GRPC_PORT):$(GRPC_PORT) -p $(HTTP_PORT):$(HTTP_PORT) -e "FEATURE_GATES=$(FEATURE_GATES)" -e "ADDRESS=" -e "TEST=$(TESTS)" -e "TIMEOUT=$(TIMEOUT)" -e "DELAY=$(DELAY)" \
+	docker run -p $(GRPC_PORT):$(GRPC_PORT) -p $(HTTP_PORT):$(HTTP_PORT) -e "FEATURE_GATES=$(FEATURE_GATES)" -e "ADDRESS=" -e "TEST=$(TESTS)" -e "SDK_NAME=$(SDK_FOLDER)" -e "TIMEOUT=$(TIMEOUT)" -e "DELAY=$(DELAY)" \


markmandel · 2020-04-09T18:47:17Z

pkg/sdkserver/localsdk.go

 		gsState:         agonesv1.GameServerStateScheduled,
 	}
+	l.logger = runtime.NewLoggerWithType(l)


Nice addition!

markmandel · 2020-04-09T18:54:51Z

pkg/sdkserver/localsdk.go

+// SetSdkName set SDK name to be added to the logs
+func (l *LocalSDKServer) SetSdkName(sdkName string) {
+	l.testSdkName = sdkName
+	l.logger = l.logger.WithField("sdkName", l.testSdkName)


Perfect. Love it.

Thanks now at least logs from local SDK server would be labeled with SDK name. Hope to label SDK test clients in the future (second half of logs).

Remove noisy npm and apt-get logs.

google-oss-robot · 2020-04-15T10:37:38Z

New changes are detected. LGTM label has been removed.

aLekSer · 2020-04-15T10:38:03Z

Rebased to a fresh master, no changes to the code were made.

agones-bot · 2020-04-15T10:45:33Z

Build Failed 😱

Build Id: 1b39bfff-48e0-42df-a0b4-a8c1a7facd42

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2020-04-15T11:27:36Z

Build Succeeded 👏

Build Id: dab77125-f1ab-486f-961f-d740cd530a40

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-e291318
image: gcr.io/agones-images/agones-sdk:1.6.0-e291318
image: gcr.io/agones-images/agones-ping:1.6.0-e291318
Linux C++ SDK (build): agonessdk-1.6.0-e291318-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-e291318.zip

A preview of the website (the last 30 builds are retained):

https://e291318-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1453/head:pr_1453 && git checkout pr_1453
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-e291318

akremsa · 2020-04-15T11:30:28Z

pkg/sdkserver/localsdk.go

 // recordRequest append request name to slice
 func (l *LocalSDKServer) recordRequest(request string) {
 	if l.testMode {
 		l.testMutex.Lock()
 		defer l.testMutex.Unlock()
 		l.requestSequence = append(l.requestSequence, request)
 	}
+	if l.testSdkName != "" {
+		l.logger.Debugf("Received %s requets", request)


Typo: request

agones-bot · 2020-04-15T11:43:00Z

Build Succeeded 👏

Build Id: 6a74bca0-1b66-408e-bff8-e50149a65920

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-fff3356
image: gcr.io/agones-images/agones-sdk:1.6.0-fff3356
image: gcr.io/agones-images/agones-ping:1.6.0-fff3356
Linux C++ SDK (build): agonessdk-1.6.0-fff3356-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-fff3356.zip

A preview of the website (the last 30 builds are retained):

https://fff3356-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1453/head:pr_1453 && git checkout pr_1453
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-fff3356

akremsa · 2020-04-15T11:52:19Z

pkg/sdkserver/localsdk.go

 		if _, ok := aSet[v]; !ok {
+			l.logger.Infof("Found an element which was not expected %s", v)


.WithField().Error() ?

Thanks, here definitely should go an error, as well as this helps me to identify one fmt.Print usage.

google-oss-robot · 2020-04-15T12:05:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akremsa, aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2020-04-15T12:05:56Z

@akremsa: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

agones-bot · 2020-04-15T12:21:20Z

Build Succeeded 👏

Build Id: 12e9fd85-fd9c-413e-a4a2-c2fe488230fa

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.6.0-189e307
image: gcr.io/agones-images/agones-sdk:1.6.0-189e307
image: gcr.io/agones-images/agones-ping:1.6.0-189e307
Linux C++ SDK (build): agonessdk-1.6.0-189e307-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.6.0-189e307.zip

A preview of the website (the last 30 builds are retained):

https://189e307-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1453/head:pr_1453 && git checkout pr_1453
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.6.0-189e307

Add more detaied logging for local SDK server. Make npm and apt-get less noisy. apt-get install openjdk-8-jre spares about 25% of output. For googleforgames#1452 . * SDK conformance tests - enhance logging Remove noisy npm and apt-get logs. * Use logrus.Entry to tag all local SDK logs. * Simple ParseEnvFlags test.

google-oss-robot requested review from dzlier-gcp and roberthbailey April 7, 2020 15:50

google-oss-robot added the size/L label Apr 7, 2020

markmandel added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Apr 7, 2020

aLekSer force-pushed the fix/sdk-conformance branch 2 times, most recently from 416d785 to 08fb8dc Compare April 8, 2020 13:13

markmandel added area/tests Unit tests, e2e tests, anything to make sure things don't break kind/cleanup Refactoring code, fixing up documentation, etc labels Apr 9, 2020

markmandel reviewed Apr 9, 2020

View reviewed changes

roberthbailey removed request for roberthbailey and dzlier-gcp April 13, 2020 08:32

markmandel removed the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Apr 14, 2020

markmandel approved these changes Apr 15, 2020

View reviewed changes

google-oss-robot assigned markmandel Apr 15, 2020

google-oss-robot added lgtm approved labels Apr 15, 2020

aLekSer added 2 commits April 15, 2020 13:37

SDK conformance tests - enhance logging

3aea05e

Remove noisy npm and apt-get logs.

Use logrus.Entry to tag all local SDK logs.

02be64c

aLekSer force-pushed the fix/sdk-conformance branch from 08fb8dc to 56ffd4c Compare April 15, 2020 10:37

google-oss-robot removed the lgtm label Apr 15, 2020

aLekSer force-pushed the fix/sdk-conformance branch 2 times, most recently from e291318 to fff3356 Compare April 15, 2020 11:25

akremsa reviewed Apr 15, 2020

View reviewed changes

Simple ParseEnvFlags test.

189e307

aLekSer force-pushed the fix/sdk-conformance branch from fff3356 to 189e307 Compare April 15, 2020 12:04

akremsa approved these changes Apr 15, 2020

View reviewed changes

aLekSer merged commit f4b8021 into googleforgames:master Apr 15, 2020

markmandel added this to the 1.6.0 milestone May 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enhance Logs readability of SDK Conformance Tests #1453

Enhance Logs readability of SDK Conformance Tests #1453

aLekSer commented Apr 7, 2020

agones-bot commented Apr 7, 2020

agones-bot commented Apr 8, 2020

agones-bot commented Apr 8, 2020

markmandel left a comment

markmandel Apr 9, 2020

markmandel Apr 9, 2020

markmandel Apr 9, 2020

markmandel Apr 9, 2020

markmandel Apr 9, 2020

aLekSer Apr 9, 2020

google-oss-robot commented Apr 15, 2020

aLekSer commented Apr 15, 2020 •

edited

Loading

agones-bot commented Apr 15, 2020

agones-bot commented Apr 15, 2020

akremsa Apr 15, 2020

agones-bot commented Apr 15, 2020

akremsa Apr 15, 2020

aLekSer Apr 15, 2020

google-oss-robot commented Apr 15, 2020

google-oss-robot commented Apr 15, 2020

agones-bot commented Apr 15, 2020

		if _, ok := aSet[v]; !ok {
		l.logger.Infof("Found an element which was not expected %s", v)

Enhance Logs readability of SDK Conformance Tests #1453

Enhance Logs readability of SDK Conformance Tests #1453

Conversation

aLekSer commented Apr 7, 2020

agones-bot commented Apr 7, 2020

agones-bot commented Apr 8, 2020

agones-bot commented Apr 8, 2020

markmandel left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

google-oss-robot commented Apr 15, 2020

aLekSer commented Apr 15, 2020 • edited Loading

agones-bot commented Apr 15, 2020

agones-bot commented Apr 15, 2020

Choose a reason for hiding this comment

agones-bot commented Apr 15, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

google-oss-robot commented Apr 15, 2020

google-oss-robot commented Apr 15, 2020

agones-bot commented Apr 15, 2020

aLekSer commented Apr 15, 2020 •

edited

Loading